Conversation
This was referenced Jan 12, 2026
labkey-alan
requested changes
Jan 15, 2026
packages/components/src/internal/components/domainproperties/actions.ts
Outdated
Show resolved
Hide resolved
packages/components/src/internal/components/domainproperties/actions.ts
Outdated
Show resolved
Hide resolved
packages/components/src/internal/components/domainproperties/DomainRow.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
816
to
819
| if ( | ||
| (type === 'TextChoice' || type === 'MultiChoice') && | ||
| !rawPropertyValidator[i]?.properties?.validValues | ||
| ) { |
Contributor
There was a problem hiding this comment.
I would define a variable isChoice below the hasExpressionStr variable above:
const isChoice = type === 'TextChoice' || type === 'MultiChoice';Then the if statement will fit on one line instead of 4, and be a little easier to read.
Suggested change
| if ( | |
| (type === 'TextChoice' || type === 'MultiChoice') && | |
| !rawPropertyValidator[i]?.properties?.validValues | |
| ) { | |
| if (isChoice && !rawPropertyValidator[i]?.properties?.validValues) { |
packages/components/src/internal/components/editable/actions.ts
Outdated
Show resolved
Hide resolved
packages/components/src/internal/components/search/QueryFilterPanel.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/internal/components/search/QueryFilterPanel.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/internal/components/search/FilterFacetedSelector.tsx
Outdated
Show resolved
Hide resolved
labkey-alan
approved these changes
Jan 19, 2026
Contributor
labkey-alan
left a comment
labkey-alan
left a comment
There was a problem hiding this comment.
Left some minor feedback but otherwise looks good.
| api?: ComponentsAPIWrapper; | ||
| canBeBlank: boolean; | ||
| disabled?: boolean; | ||
| field?: QueryColumn; |
Contributor
There was a problem hiding this comment.
field is always passed, so it should be defined as: field: QueryColumn. If it could be undefined then the type should be field: QueryColumn | undefined.
Suggested change
| field?: QueryColumn; | |
| field: QueryColumn; |
| fieldFilters: Filter.IFilter[]; | ||
| fieldKey: string; | ||
| onFieldFilterUpdate?: (newFilters: Filter.IFilter[], index) => void; | ||
| onFieldFilterUpdate?: (newFilter: Filter.IFilter[]) => void; |
Contributor
There was a problem hiding this comment.
onFieldFilterUpdate is always passed so it should be defined as:
Suggested change
| onFieldFilterUpdate?: (newFilter: Filter.IFilter[]) => void; | |
| onFieldFilterUpdate: (newFilter: Filter.IFilter[]) => void; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR enables "Multi Choice" data type in domain designer and supports editing/sorting multi values in the app.
Related Pull Requests
Changes
SelectInputto skipJoinValues to align with its actual usageFilterFacetedSelectorandQueryFilterPanelto handle array value selecting for MVTC